Title: [115494] trunk/Source/WebCore
- Revision
- 115494
- Author
- [email protected]
- Date
- 2012-04-27 14:36:19 -0700 (Fri, 27 Apr 2012)
Log Message
[V8] Pass Isolate to V8BindingPerIsolateData::current()
https://bugs.webkit.org/show_bug.cgi?id=85023
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to V8BindingPerIsolateData::current().
No tests. No change in behavior.
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::current):
(WebCore::v8ExternalString):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (115493 => 115494)
--- trunk/Source/WebCore/ChangeLog 2012-04-27 21:16:29 UTC (rev 115493)
+++ trunk/Source/WebCore/ChangeLog 2012-04-27 21:36:19 UTC (rev 115494)
@@ -1,3 +1,19 @@
+2012-04-26 Kentaro Hara <[email protected]>
+
+ [V8] Pass Isolate to V8BindingPerIsolateData::current()
+ https://bugs.webkit.org/show_bug.cgi?id=85023
+
+ Reviewed by Nate Chapin.
+
+ The objective is to pass Isolate around in V8 bindings.
+ This patch passes Isolate to V8BindingPerIsolateData::current().
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8Binding.h:
+ (WebCore::V8BindingPerIsolateData::current):
+ (WebCore::v8ExternalString):
+
2012-04-27 Dimitri Glazkov <[email protected]>
Unreviewed, rolling out r115484.
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (115493 => 115494)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-04-27 21:16:29 UTC (rev 115493)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-04-27 21:36:19 UTC (rev 115494)
@@ -105,9 +105,9 @@
return static_cast<V8BindingPerIsolateData*>(isolate->GetData());
}
- static V8BindingPerIsolateData* current()
+ static V8BindingPerIsolateData* current(v8::Isolate* isolate = 0)
{
- return get(v8::Isolate::GetCurrent());
+ return isolate ? static_cast<V8BindingPerIsolateData*>(isolate->GetData()) : get(v8::Isolate::GetCurrent());
}
static void dispose(v8::Isolate*);
@@ -250,7 +250,7 @@
if (!stringImpl)
return v8::String::Empty();
- V8BindingPerIsolateData* data = "" ? static_cast<V8BindingPerIsolateData*>(isolate->GetData()) : V8BindingPerIsolateData::current();
+ V8BindingPerIsolateData* data = ""
return data->stringCache()->v8ExternalString(stringImpl);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
