Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 99d852ceffcf11dc07176f8ffd9f967bc594317c
https://github.com/WebKit/WebKit/commit/99d852ceffcf11dc07176f8ffd9f967bc594317c
Author: Yusuke Suzuki <[email protected]>
Date: 2026-07-24 (Fri, 24 Jul 2026)
Changed paths:
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[CMake] Fix target names for executables
https://bugs.webkit.org/show_bug.cgi?id=320140
rdar://183079408
Reviewed by Keith Miller.
After 317795@main, --target jsc for example does not produce a JSC shell
binary which is code-signed. This patch fixes the issue by setting a
post-build task only for "EXECUTABLE" target. We do not do it for the
other type of targets since POST_BUILD in Ninja is executed just after
linking, and frameworks requires the other jobs before codesining the
framework (WebKit.framework linking -> XPC services are linked against
this framework -> XPC services are code-signed -> codesign
WebKit.framework). But EXECUTABLE does not need to code-sign the other
things before sealing. So using POST_BUILD is fine.
We keep jsc_CodeSign etc. as a custom target which relies on jsc target
to keep the downstream use of this name without hassle.
* Source/cmake/WebKitMacros.cmake:
Canonical link: https://commits.webkit.org/317872@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
