Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 860d7d88a9b5c4e1294ee415a4c2b4cbeb89974b
https://github.com/WebKit/WebKit/commit/860d7d88a9b5c4e1294ee415a4c2b4cbeb89974b
Author: Devin Rousso <[email protected]>
Date: 2026-07-23 (Thu, 23 Jul 2026)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Scripts/GenerateSettings.rb
M Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb
M Source/WebCore/Scripts/SettingsTemplates/Settings.h.erb
M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
M Source/WebCore/inspector/agents/InspectorPageAgent.h
Log Message:
-----------
Web Inspector: `inspectorOverride` should apply to `SettingsValues`
https://bugs.webkit.org/show_bug.cgi?id=319302
Reviewed by Yusuke Suzuki.
IDL bindings consumes settings via the raw `SettingsValues` instead of the
corresponding getter on `Settings`.
As a result, `inspectorOverride` has no effect on it since that intercepts the
getter on `Settings` instead of modifying `SettingsValues`.
It's probably far more common to read a `Settings` value than write it, so move
this logic to the setter instead.
As a result, the `inspectorOverride` is now used to store the old value and any
non-`inspectorOverride` set value since then.
This allows for the `inspectorOverride` setter to modify the underlying
`SettingsValues`.
When the `inspectorOverride` is removed, the stored value is used to (re)set
the `SettingsValues`.
This has the added benefit of removing an extra function call when getting
`Settings` that have an `inspectorOverride`.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Scripts/GenerateSettings.rb:
* Source/WebCore/Scripts/SettingsTemplates/Settings.h.erb:
* Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb:
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::overrideSetting):
(WebCore::InspectorPageAgent::overrideSettingByModifyingValue): Deleted.
* Source/WebCore/inspector/agents/InspectorPageAgent.h:
Canonical link: https://commits.webkit.org/317841@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
