Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f554adccfd9e2638290f0c899877cf155af3651d
https://github.com/WebKit/WebKit/commit/f554adccfd9e2638290f0c899877cf155af3651d
Author: Aakash Jain <[email protected]>
Date: 2026-07-23 (Thu, 23 Jul 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Don't blame PR author for pre-existing flaky layout test failures
https://bugs.webkit.org/show_bug.cgi?id=319981
rdar://problem/182908056
Reviewed by Ryan Haddad.
A pre-existing flaky layout test can fail with the change and then pass on the
clean-tree run
(because it is flaky), which made AnalyzeLayoutTestsResults report it as a new
failure and blame
the PR author.
Use the results-db-filtered failure lists, which already have pre-existing
failures removed,
so such a test is never counted as new (nor toward the "too many flaky
failures" limit).
This relies on those lists being complete, so we no longer stop the results-db
lookup at the first
non-pre-existing failure. run-layout-tests-without-change also skips those
pre-existing tests, since
the analysis ignores them anyways.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests): Add MAX_FAILURES_TO_CHECK_RESULTS_DB.
(RunWebKitTests.filter_failures_using_results_db):
(RunWebKitTestsWithoutChange.setLayoutTestCommand):
(AnalyzeLayoutTestsResults.run):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestFilterLayoutTestFailuresUsingResultsDB):
(TestRunWebKitTestsWithoutChange.test_run_subtest_skips_results_db_pre_existing):
Canonical link: https://commits.webkit.org/317804@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
