Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e59e295bb71290f66f6011096123ad962956ff22
https://github.com/WebKit/WebKit/commit/e59e295bb71290f66f6011096123ad962956ff22
Author: Elliott Williams <[email protected]>
Date: 2026-07-23 (Thu, 23 Jul 2026)
Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/PlatformIOS.cmake
M Source/JavaScriptCore/Scripts/process-entitlements.sh
M Source/JavaScriptCore/shell/PlatformCocoa.cmake
M Source/WebCore/PlatformCocoa.cmake
M Source/WebKit/CMakeLists.txt
M Source/WebKit/PlatformCocoa.cmake
M Source/WebKit/PlatformMac.cmake
M Source/WebKit/Scripts/process-entitlements.sh
M Source/WebKitLegacy/PlatformIOS.cmake
M Source/cmake/OptionsCocoa.cmake
M Source/cmake/OptionsIOS.cmake
M Source/cmake/WebKitCommon.cmake
A Source/cmake/WebKitEntitlements.cmake
M Source/cmake/WebKitMacros.cmake
M Source/cmake/WebKitXcodeSDK.cmake
M Tools/DumpRenderTree/PlatformMac.cmake
M Tools/MiniBrowser/mac/CMakeLists.txt
M Tools/TestWebKitAPI/PlatformMac.cmake
M Tools/TestWebKitAPI/Scripts/process-entitlements.sh
M Tools/WebKitTestRunner/PlatformMac.cmake
Log Message:
-----------
[CMake] Centralize code signing and add missing entitlements
https://bugs.webkit.org/show_bug.cgi?id=319641
Reviewed by Richard Robinson and Zak Ridouh.
Reland shared codesigning infrastructure added in 317671@main and add
logic to fully process entitlements.
Add a WEBKIT_GENERATE_ENTITLEMENTS function which crafts invocations of
a `process-entitlements.sh` script to generate an entitlements plist and
sets it as the target's CODE_SIGN_ENTITLEMENTS path. It supports
internal-SDK only entitlements and including logic from WebKitAdditions.
* Source/JavaScriptCore/Scripts/process-entitlements.sh: Hide expected
output from PlistBuddy to keep build logs clean.
* Source/JavaScriptCore/shell/PlatformCocoa.cmake:
* Source/WebKit/CMakeLists.txt: Add some manual dependency edges to make
the XPC services and WebKit.framework sign in the correct order.
* Source/WebKit/PlatformCocoa.cmake:
* Source/WebKit/PlatformMac.cmake: Use the WEBKIT_EXECUTABLE_* macros to
generate XPC variants that have a codesigning task.
* Source/WebKit/Scripts/process-entitlements.sh: Ditto JSC's change.
* Source/cmake/OptionsCocoa.cmake:
* Source/cmake/OptionsIOS.cmake:
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitEntitlements.cmake: Added.
* Source/cmake/WebKitMacros.cmake: Building on 317671@main, if a target
has an entitlements plist to sign with, automatically track it as a
dependency.
* Source/cmake/WebKitXcodeSDK.cmake: Remove the
WEBKIT_PROCESS_ENTITLEMENTS function that was used by JSC and did some
of the above. As a drive-by, rename the project-wide `_sdk_version`
variable to WEBKIT_SDK_VERSION.
* Tools/MiniBrowser/mac/CMakeLists.txt:
* Tools/TestWebKitAPI/PlatformMac.cmake:
* Tools/TestWebKitAPI/Scripts/process-entitlements.sh:
Canonical link: https://commits.webkit.org/317795@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
