Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a7db8ec7ef72f912d9caa27928be356bb7b7bf7a
https://github.com/WebKit/WebKit/commit/a7db8ec7ef72f912d9caa27928be356bb7b7bf7a
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-22 (Wed, 22 Jul 2026)
Changed paths:
R
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window.html
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=blank-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=blob-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=data-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=origin-expected.txt
R
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window.html
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window_urlType=blank-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window_urlType=blob-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window_urlType=origin-expected.txt
M Tools/Scripts/webkitpy/w3c/test_importer.py
M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Log Message:
-----------
[WPT import] META: variant= is not expanded into the generated wrapper for
.window.js/.worker.js templated tests
https://bugs.webkit.org/show_bug.cgi?id=319965
rdar://182891397
Reviewed by Sam Sneddon.
import-w3c-tests only copied META: variant= lines into the generated
HTML wrapper for .any.js tests. For .window.js and .worker.js tests,
write_html_files_for_templated_js_tests() wrote a wrapper with no
variant info at all, so WebKit's test runner never split the test
into one run per variant. The test instead ran once with an empty
location.search, which addWindow-urlType.window.js and
addIframe-urlType.window.js treat as an unhandled urlType and throw.
Read variants from the .window.js/.worker.js source the same way
.any.js already does, and pass them through to the generated
wrapper's META: variant= comments so each variant runs and gets its
own expected result.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window-expected.txt:
Removed.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window.html:
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=blank-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=blob-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=data-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addIframe-urlType.window_urlType=origin-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window-expected.txt:
Removed.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window.html:
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window_urlType=blank-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window_urlType=blob-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/remote-context-helper-tests/addWindow-urlType.window_urlType=origin-expected.txt:
Added.
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.write_html_files_for_templated_js_tests):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:
Canonical link: https://commits.webkit.org/317729@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
