Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 34482f630e94bffa517a6b298ea6b001ea37d03f
https://github.com/WebKit/WebKit/commit/34482f630e94bffa517a6b298ea6b001ea37d03f
Author: Megan Gardner <[email protected]>
Date: 2026-07-21 (Tue, 21 Jul 2026)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/rendering/TextBoxPainter.cpp
Log Message:
-----------
[Selection] ::selection text-decoration is not painted when only the
selection has a decoration.
https://bugs.webkit.org/show_bug.cgi?id=319947
rdar://182864748
Reviewed by Wenson Hsieh.
hasDecoration in paintForegroundAndDecorations only accounted for the
originating element, custom highlights,
and spelling/grammar — not ::selection. So when text had no decoration of its
own and only ::selection did,
the decoration-paint path was skipped and the selection's decoration never
painted. Add a hasSelectionDecoration
check so the path runs, making selection-text-decoration-currentcolor.html and
target-text-005.html pass.
imported/w3c/web-platform-tests/css/css-pseudo/selection-text-decoration-currentcolor.html
imported/w3c/web-platform-tests/css/css-pseudo/target-text-005.html
* LayoutTests/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
Canonical link: https://commits.webkit.org/317695@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
