Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9c88a404d6b27394838342bd15dbade0b4f9cfa8
https://github.com/WebKit/WebKit/commit/9c88a404d6b27394838342bd15dbade0b4f9cfa8
Author: Zak Ridouh <[email protected]>
Date: 2026-07-15 (Wed, 15 Jul 2026)
Changed paths:
M Tools/Scripts/webkitpy/style/checker.py
M Tools/Scripts/webkitpy/style/checker_unittest.py
M Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes.py
M
Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes_unittest.py
Log Message:
-----------
[check-webkit-style] Run the deprecated js-test include checker on LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=319464
rdar://182275985
Reviewed by Tim Nguyen.
The checker added in 313204@main never ran: every LayoutTests/ file is
skipped before a checker is dispatched, so the .html tests that carry these
includes were never linted. The unit tests passed only by calling the
checker directly.
Un-skip non-imported LayoutTests HTML/XHTML markup and route it to the
DeprecatedJSTestIncludesChecker. Also require the include to be a whole path
segment so custom-js-test-pre.js isn't flagged, and allow a trailing
* Tools/Scripts/webkitpy/style/checker.py:
(CheckerDispatcher._is_lintable_layout_test_markup):
(CheckerDispatcher.should_skip_without_warning):
(CheckerDispatcher._create_checker):
* Tools/Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherSkipTest.test_should_skip_without_warning__true):
(CheckerDispatcherSkipTest.test_should_skip_without_warning__false):
(CheckerDispatcherDispatchTest.assert_checker_deprecated_js_test_includes):
(CheckerDispatcherDispatchTest.test_deprecated_js_test_includes_paths):
* Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes.py:
(DeprecatedJSTestIncludesChecker):
* Tools/Scripts/webkitpy/style/checkers/deprecated_js_test_includes_unittest.py:
(DeprecatedJSTestIncludesCheckerTest.test_flags_pre_include_deep_relative):
(DeprecatedJSTestIncludesCheckerTest.test_does_not_flag_similarly_named_helper):
(DeprecatedJSTestIncludesCheckerTest):
(DeprecatedJSTestIncludesCheckerTest.test_flags_with_fragment):
Canonical link: https://commits.webkit.org/317222@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
