Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 33a88e318eedd4ad6069b1833594c777b3e4ccb0
https://github.com/WebKit/WebKit/commit/33a88e318eedd4ad6069b1833594c777b3e4ccb0
Author: Richard Robinson <[email protected]>
Date: 2026-07-14 (Tue, 14 Jul 2026)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.h
M Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.mm
M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h
M Source/WebCore/editing/cocoa/EditorCocoa.mm
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/page/ContextMenuClient.h
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebCore/platform/TextRecognitionResult.h
M Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
M Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.mm
M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h
M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm
M Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm
M Source/WebKit/Shared/TextRecognitionResult.serialization.in
M Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebContextMenuProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h
M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h
M Tools/TestWebKitAPI/Helpers/cocoa/ImageAnalysisTestingUtilities.h
M Tools/TestWebKitAPI/Helpers/cocoa/ImageAnalysisTestingUtilities.mm
M
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/FullscreenVideoTextRecognition.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ImageAnalysisTests.mm
Log Message:
-----------
Unify IMAGE_ANALYSIS_ENHANCEMENTS and IMAGE_ANALYSIS flags
https://bugs.webkit.org/show_bug.cgi?id=319359
rdar://182168302
Reviewed by Abrar Rahman Protyasha.
They have the same value now.
Tests:
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/FullscreenVideoTextRecognition.mm
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ImageAnalysisTests.mm
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.mm:
* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebCore/editing/cocoa/EditorCocoa.mm:
(WebCore::selectionInImageOverlayAsAttributedString):
* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/page/ContextMenuClient.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/platform/TextRecognitionResult.h:
* Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:
* Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::installImageOverlay):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.mm:
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h:
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::createImageAnalyzer):
(WebKit::createImageAnalyzerRequest):
(WebKit::makeTextRecognitionResult):
(WebKit::languageIdentifierSupportsLiveText):
* Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::defaultTextRecognitionInVideosEnabled):
(WebKit::defaultVisualTranslationEnabled):
(WebKit::defaultRemoveBackgroundEnabled):
* Source/WebKit/Shared/TextRecognitionResult.serialization.in:
* Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction _elementActionWithType:customTitle:assistant:disabled:]):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
* Source/WebKit/UIProcess/WebContextMenuProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:
* Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
(-[WKActionSheetAssistant
handleElementActionWithType:element:needsInteraction:]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsNearMarkedText:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView
requestPreferredArrowDirectionForEditMenuWithCompletionHandler:]):
(-[WKContentView _handleTapOverInteractiveControl:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView
_internalSelectTextForContextMenuWithLocationInView:completionHandler:]):
(-[WKContentView _shouldIgnoreTouchEvent:]):
(-[WKContentView
deferringGestureRecognizer:shouldDeferGesturesForEventThatWillBeginAction:]):
(-[WKContentView buildMenuForWebViewWithBuilder:]):
(-[WKContentView _setUpImageAnalysis]):
(-[WKContentView _tearDownImageAnalysis]):
(-[WKContentView
requestTextRecognition:imageData:sourceLanguageIdentifier:targetLanguageIdentifier:completionHandler:]):
(-[WKContentView
_completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):
(-[WKContentView beginTextRecognitionForFullscreenVideo:playerViewController:]):
(-[WKContentView cancelTextRecognitionForFullscreenVideo:]):
(-[WKContentView isTextRecognitionInFullscreenVideoEnabled]):
(-[WKContentView beginTextRecognitionForVideoInElementFullscreen:bounds:]):
(-[WKContentView cancelTextRecognitionForVideoInElementFullscreen]):
(-[WKContentView _shouldAvoidSecurityHeuristicScoreUpdates]):
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h:
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::appendRemoveBackgroundItemToControlledImageMenuIfNeeded):
(WebKit::WebContextMenuProxyMac::removeBackgroundFromControlledImage):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::mouseUp):
(WebKit::WebViewImpl::requestTextRecognition):
(WebKit::WebViewImpl::imageAnalysisOverlayViewHasCursorAtPoint const):
(WebKit::WebViewImpl::beginTextRecognitionForVideoInElementFullscreen):
(WebKit::WebViewImpl::cancelTextRecognitionForVideoInElementFullscreen):
* Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h:
* Tools/TestWebKitAPI/Helpers/cocoa/ImageAnalysisTestingUtilities.h:
* Tools/TestWebKitAPI/Helpers/cocoa/ImageAnalysisTestingUtilities.mm:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/FullscreenVideoTextRecognition.mm:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ImageAnalysisTests.mm:
Canonical link: https://commits.webkit.org/317174@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
