Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 702cd85ba0a2e9acaaf2dc8a73b645f36428f198
https://github.com/WebKit/WebKit/commit/702cd85ba0a2e9acaaf2dc8a73b645f36428f198
Author: Jer Noble <[email protected]>
Date: 2026-07-14 (Tue, 14 Jul 2026)
Changed paths:
M Source/WTF/wtf/MainThread.cpp
M Source/WTF/wtf/MainThread.h
M Source/WTF/wtf/cocoa/MainThreadCocoa.mm
M Source/WebCore/dom/ActiveDOMObject.cpp
M Source/WebCore/platform/Supplementable.h
M Source/WebCore/platform/Timer.cpp
M Source/WebCore/platform/Timer.h
M TestExpectations/apitests
Log Message:
-----------
REGRESSION(312759@main): Multiple TestWebKitAPI.WebKitLegacy.* fail with
debug assert
rdar://181539181
https://bugs.webkit.org/show_bug.cgi?id=318924
Reviewed by Ryosuke Niwa.
Restore the behavior of the previous ASSERT by adding a new method,
canCurrentThreadIDAccessThreadLocalData(), which has similar behavior to the
existing
canCurrentThreadAccessThreadLocalData() method, which can be implemented in
terms of the
canCurrentThreadIDAccessThreadLocalData() method. Partially revert the changes
to Timer and
ActiveDOMObject by re-adopting the ID-based version of
canCurrentThreadAccessThreadLocalData().
* Source/WTF/wtf/MainThread.cpp:
(WTF::canCurrentThreadIDAccessThreadLocalData):
* Source/WTF/wtf/MainThread.h:
* Source/WTF/wtf/cocoa/MainThreadCocoa.mm:
(WTF::initializeApplicationUIThread):
(WTF::initializeWebThread):
(WTF::canCurrentThreadAccessThreadLocalData):
(WTF::canCurrentThreadIDAccessThreadLocalData):
* Source/WebCore/dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* Source/WebCore/platform/Supplementable.h:
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::requireSupplement):
* Source/WebCore/platform/Timer.cpp:
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::start):
(WebCore::TimerBase::stopSlowCase):
(WebCore::TimerBase::setNextFireTime):
(WebCore::TimerBase::canAccessOnCurrentThread const): Deleted.
* Source/WebCore/platform/Timer.h:
(WebCore::TimerBase::isActive const):
* TestExpectations/apitests:
Canonical link: https://commits.webkit.org/317153@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
