Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0709f86af273dea8e8e983282afa93142313b32b
      
https://github.com/WebKit/WebKit/commit/0709f86af273dea8e8e983282afa93142313b32b
  Author: Ahmad Saleem <[email protected]>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js

  Log Message:
  -----------
  Web Inspector: formatted location string always drops the column number
https://bugs.webkit.org/show_bug.cgi?id=319293
rdar://182130776

Reviewed by Devin Rousso.

formattedLocationString() passed this.formattedColumn, which is not a getter
(only formattedColumnNumber exists), so the argument was undefined. Both
column-appending branches in _locationString() guard on numeric comparisons,
and `undefined > n` is always false, so the column was silently dropped.

No test: this is a typo / copy/paste fix, and I looked into the test harness
but couldn't find a way to make it testable.

* Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js:
(WI.SourceCodeLocation.prototype.formattedLocationString):

Canonical link: https://commits.webkit.org/317111@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to