Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: eb017c5dbb25ecbe522514bd2cfedf1b2a1892bb
https://github.com/WebKit/WebKit/commit/eb017c5dbb25ecbe522514bd2cfedf1b2a1892bb
Author: Andy Estes <[email protected]>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
A LayoutTests/media/wireless-playback-media-player/route-name-expected.txt
A
LayoutTests/media/wireless-playback-media-player/route-name-fallback-expected.txt
A LayoutTests/media/wireless-playback-media-player/route-name-fallback.html
A LayoutTests/media/wireless-playback-media-player/route-name.html
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
M Source/WebCore/Modules/modern-media-controls/controls/placard.js
M Source/WebCore/Modules/modern-media-controls/media/placard-support.js
M Source/WebCore/platform/audio/ios/MediaDeviceRoute.h
M Source/WebCore/platform/audio/ios/MediaDeviceRoute.mm
M Source/WebCore/platform/graphics/MediaPlaybackTarget.h
M Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.cpp
M Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.h
M Source/WebCore/platform/graphics/MediaPlayer.cpp
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebCore/platform/graphics/MediaPlayerPrivate.h
M Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp
M Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.h
M Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h
M Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm
M Source/WebCore/platform/mock/MediaPlaybackTargetMock.h
M Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.h
M Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.mm
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.h
M Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.mm
M
Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.serialization.in
M Source/WebKit/Platform/cocoa/MediaPlaybackTargetSerialized.h
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.serialization.in
Log Message:
-----------
[iOS] Placard may show incorrect route name during wireless playback
https://bugs.webkit.org/show_bug.cgi?id=319214
rdar://182073085
Reviewed by Jer Noble.
The placard used for wireless playback was hardcoded to display "AirPlay", but
when using
AVSystemRouting the route may have a different name. Updated the placard to
show the correct name
based on the MediaDeviceRoute.
Tests: media/wireless-playback-media-player/route-name-fallback.html
media/wireless-playback-media-player/route-name.html
* LayoutTests/media/wireless-playback-media-player/route-name-expected.txt:
Added.
*
LayoutTests/media/wireless-playback-media-player/route-name-fallback-expected.txt:
Added.
* LayoutTests/media/wireless-playback-media-player/route-name-fallback.html:
Added.
* LayoutTests/media/wireless-playback-media-player/route-name.html: Added.
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::externalDeviceDisplayName const):
(WebCore::MediaControlsHost::externalDeviceRouteName const):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/Modules/modern-media-controls/controls/placard.js:
* Source/WebCore/Modules/modern-media-controls/media/placard-support.js:
(PlacardSupport.prototype._updateAirPlayPlacard):
(PlacardSupport):
* Source/WebCore/platform/audio/ios/MediaDeviceRoute.h:
* Source/WebCore/platform/audio/ios/MediaDeviceRoute.mm:
(WebCore::MediaDeviceRoute::routeName const):
* Source/WebCore/platform/graphics/MediaPlaybackTarget.h:
* Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.cpp:
(WebCore::MediaPlaybackTargetWirelessPlayback::routeName const):
* Source/WebCore/platform/graphics/MediaPlaybackTargetWirelessPlayback.h:
* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::wirelessPlaybackRouteName const):
* Source/WebCore/platform/graphics/MediaPlayer.h:
* Source/WebCore/platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::wirelessPlaybackRouteName const):
* Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.cpp:
(WebCore::MediaPlayerPrivateWirelessPlayback::wirelessPlaybackRouteName const):
* Source/WebCore/platform/graphics/MediaPlayerPrivateWirelessPlayback.h:
* Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h:
* Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm:
(WebCore::MediaPlaybackTargetCocoa::routeName const):
* Source/WebCore/platform/mock/MediaPlaybackTargetMock.h:
* Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.h:
* Source/WebCore/testing/cocoa/WebMockMediaDeviceRoute.mm:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
* Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.h:
(WebKit::MediaPlaybackTargetContextSerialized::routeName const):
* Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.mm:
(WebKit::MediaPlaybackTargetContextSerialized::MediaPlaybackTargetContextSerialized):
*
Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.serialization.in:
* Source/WebKit/Platform/cocoa/MediaPlaybackTargetSerialized.h:
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::updateCachedState):
(WebKit::MediaPlayerPrivateRemote::wirelessPlaybackRouteName const):
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h:
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.serialization.in:
Canonical link: https://commits.webkit.org/317107@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
