Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ddf079fd729f2f1b4ce80b33683e79b489bd14aa
https://github.com/WebKit/WebKit/commit/ddf079fd729f2f1b4ce80b33683e79b489bd14aa
Author: Sam Sneddon <[email protected]>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py
A
Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_integrationtest.py
M Tools/Scripts/webkitpy/w3c/wpt_linter.py
A Tools/Scripts/webkitpy/w3c/wpt_linter_integrationtest.py
Log Message:
-----------
REGRESSION(314752@main): [Intel] WPT server fails to start due to unbuildable
dependencies
https://bugs.webkit.org/show_bug.cgi?id=317060
rdar://179542775
Reviewed by Basuke Suzuki.
wpt serve fails to start on EWS's Intel macOS bots because the import
in 314752@main flipped the serve command's commands.json entry from
"virtualenv": false to true.
Due to a bug, WPT includes its supposedly optional requirements,
pulling in aioquic, whose loose pyopenssl>=24 constraint lets pip's
legacy resolver pick a pyOpenSSL release that in turn requires
cryptography>=49. This is the first release after cryptography stopped
supporting and publishing wheels for x86_64 macOS, causing pip to
attempt to build it from source, which fails because cryptography has
native dependencies which may not be installed, and server startup
times out.
Dependencies for wpt's own tools should come from webkitcorepy's
AutoInstaller rather than pip, matching the rest of webkitpy. wpt
serve doesn't actually have any real dependencies of its own so pass
--venv <path> --skip-venv-setup when invoking it, which skips venv
creation and the pip install entirely. wpt lint's one real dependency,
pyyaml, moves to the AutoInstaller instead, and gets the same flags
for the same reason.
Add integration tests that drive the real WebPlatformTestServer and
WPTLinter classes rather than mocking the subprocess out so we get
coverage of our ability to actually run the imported code outside of
run-webkit-tests.
* Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer.__init__):
*
Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_integrationtest.py:
Added.
(WPTServeIntegrationTest):
(WPTServeIntegrationTest.integration_test_serve_starts_without_pip_install):
* Tools/Scripts/webkitpy/w3c/wpt_linter.py:
(WPTLinter.lint):
(WPTLinter._run_lint):
* Tools/Scripts/webkitpy/w3c/wpt_linter_integrationtest.py: Added.
(WPTLintIntegrationTest):
(WPTLintIntegrationTest.integration_test_lint_runs_without_venv):
(WPTLintIntegrationTest.integration_test_lint_reports_multiple_errors):
Canonical link: https://commits.webkit.org/317106@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
