Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6fec41aa12c4019412b33da9205cbba9aea7472d
https://github.com/WebKit/WebKit/commit/6fec41aa12c4019412b33da9205cbba9aea7472d
Author: Chris Dumez <[email protected]>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Log Message:
-----------
Fix EnabledByQuirk value-missing assertion checking the wrong extended
attribute
https://bugs.webkit.org/show_bug.cgi?id=319231
Reviewed by Darin Adler and Brent Fulgham.
The generation-time assert that verifies a value was specified for
[EnabledByQuirk] was mistakenly checking the {DisabledByQuirk} extended
attribute instead of {EnabledByQuirk}. As a result, an IDL declaration
written as [EnabledByQuirk] with no "=value" would not trip the assert
(undef eq "VALUE_IS_MISSING" is false); the generator would instead
split on the literal "VALUE_IS_MISSING" and emit broken C++ such as
->quirks().VALUE_IS_MISSINGQuirk() rather than failing loudly with a
clear diagnostic. Check the attribute's own key so the assert fires as
intended, matching the sibling EnabledConditionallyReadWriteBySetting and
DisabledByQuirk blocks.
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateRuntimeEnableConditionalString):
Canonical link: https://commits.webkit.org/317091@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
