Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d37346b67647056a67cd1d2e00d280cd4c2ae608
https://github.com/WebKit/WebKit/commit/d37346b67647056a67cd1d2e00d280cd4c2ae608
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-12 (Sun, 12 Jul 2026)
Changed paths:
M Source/WebCore/dom/DocumentFullscreen.cpp
Log Message:
-----------
Remove redundant pending-fullscreen-element re-check in requestFullscreen
https://bugs.webkit.org/show_bug.cgi?id=318316
rdar://181103911
Reviewed by Chris Dumez.
The queued task in DocumentFullscreen::requestFullscreen already bails out
when m_pendingFullscreenElement no longer matches the requested element,
with a dedicated error message. The hidden-document guard re-tested the
same condition as an OR'd disjunct, but nothing between the two checks
mutates m_pendingFullscreenElement, so the disjunct can never be the reason
that branch is taken. It would also have reported the wrong error. Drop it.
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::requestFullscreen):
Canonical link: https://commits.webkit.org/317020@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
