Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 050117b8ea1118fbd13e6fa410bbd723ec2bf972
https://github.com/WebKit/WebKit/commit/050117b8ea1118fbd13e6fa410bbd723ec2bf972
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-12 (Sun, 12 Jul 2026)
Changed paths:
M Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp
Log Message:
-----------
AudioParamTimeline::cancelAndHoldAtTime discards exception from second
insertEvent
https://bugs.webkit.org/show_bug.cgi?id=319186
rdar://182035131
Reviewed by Chris Dumez.
When cancelAndHoldAtTime() splits a SetValueCurve, it inserts a
replacement curve event and then a trailing SetValue event. The second
insertEvent() call ignored its own result and re-checked the already-
validated result from the first insert, so any exception from the
second insert would be silently swallowed.
Capture and check the second insert's own result.
No new tests: the trailing SetValue lands exactly at the truncated
curve's end (a non-overlap) with all later events already removed, so
the second insert cannot throw today. This is a latent correctness fix,
not a web-observable bug.
* Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::cancelAndHoldAtTime):
Canonical link: https://commits.webkit.org/317019@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
