Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3ec2988be5d6d7bc4fcf584274e086a8911870a8
https://github.com/WebKit/WebKit/commit/3ec2988be5d6d7bc4fcf584274e086a8911870a8
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-12 (Sun, 12 Jul 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/feconvolvematrix-order-removal-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/feconvolvematrix-order-removal.html
A
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/reference/feconvolvematrix-order-removal-ref.html
M Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp
Log Message:
-----------
feConvolveMatrix: removing an invalid order attribute leaves the filter
permanently disabled
https://bugs.webkit.org/show_bug.cgi?id=318325
rdar://181109552
Reviewed by Taher Ali.
When feConvolveMatrix parses an invalid order (e.g. order="0"), it sets
m_hasInvalidOrderAttribute so createFilterEffect() bails out and the filtered
element is not displayed. Removing the order attribute produces an empty value,
which parseNumberOptionalNumber() rejects, so the code took the parse-failure
path and kept m_hasInvalidOrderAttribute set. The filter therefore stayed
disabled even though a missing order attribute is valid and defaults to 3x3.
Treat an empty/absent order value as the valid 3x3 default: reset orderX/orderY
to the initial value and clear m_hasInvalidOrderAttribute, distinct from a
present-but-malformed value which continues to invalidate the primitive.
Tests:
imported/w3c/web-platform-tests/css/filter-effects/feconvolvematrix-order-removal.html
imported/w3c/web-platform-tests/css/filter-effects/reference/feconvolvematrix-order-removal-ref.html
*
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/feconvolvematrix-order-removal-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/feconvolvematrix-order-removal.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/reference/feconvolvematrix-order-removal-ref.html:
Added.
* Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::attributeChanged):
Canonical link: https://commits.webkit.org/317005@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
