Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7f1a23389fefcca828059bdb2f1f5242802ef5bc
https://github.com/WebKit/WebKit/commit/7f1a23389fefcca828059bdb2f1f5242802ef5bc
Author: Alan Baradlay <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[cleanup] Route the right-to-left column flip through the flex item instead
of the renderer
https://bugs.webkit.org/show_bug.cgi?id=318464
Reviewed by Antti Koivisto.
flipForRightToLeftColumn was the last place that read and wrote the renderer's
flow-aware location directly. Have it read and write the flex item's
flowAwareLocation and apply that with setFlexItemGeometry, like every other flex
geometry writer now does. It runs last, after the other item-based writers have
applied, so the item's location still equals the renderer's going in and the
result is identical.
With that, nothing reads the renderer's flow-aware location anymore, so remove
the now-unused flowAwareLocationForFlexItem. No change in behavior.
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareLocationForFlexItem): Deleted.
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
Canonical link: https://commits.webkit.org/316921@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
