Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8d1730723e6d7186b274f471c7e5676647d4bd88
https://github.com/WebKit/WebKit/commit/8d1730723e6d7186b274f471c7e5676647d4bd88
Author: Youenn Fablet <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/objc/components/video_codec/RTCVideoEncoderH264.mm
M
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/objc/components/video_codec/RTCVideoEncoderH265.mm
M Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/CMUtilities.mm
Log Message:
-----------
VTB encoders should check for kCMSampleAttachmentKey_NotSync value if present
rdar://181715555
https://bugs.webkit.org/show_bug.cgi?id=319081
Reviewed by Jean-Yves Avenard.
As per documentation, kCMSampleAttachmentKey_NotSync can be present and its
value may be 0.
In that case, we should treat the frame as a key frame.
We make the code more robust by covering this case.
We also apply the same rule for WebCore helper routines.
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264
frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:duration:rotation:isKeyFrameRequired:]):
*
Source/ThirdParty/libwebrtc/Source/webrtc/webkit_sdk/objc/components/video_codec/RTCVideoEncoderH265.mm:
(-[RTCVideoEncoderH265
frameWasEncoded:flags:sampleBuffer:width:height:renderTimeMs:timestamp:rotation:]):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::isCMSampleBufferAttachmentRandomAccess):
* Source/WebCore/platform/graphics/cocoa/CMUtilities.mm:
(WebCore::isCMSampleBufferRandomAccess):
Canonical link: https://commits.webkit.org/316889@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
