Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56441d3640475ce4cceb7f56e6a283f71dc2fef2
https://github.com/WebKit/WebKit/commit/56441d3640475ce4cceb7f56e6a283f71dc2fef2
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-07-10 (Fri, 10 Jul 2026)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
Log Message:
-----------
[Netflix.com] Unable to PiP video after navigating to another episode
https://bugs.webkit.org/show_bug.cgi?id=318964
rdar://181092025
Reviewed by Jer Noble.
Only the synchronous hostingContext() API was implemented by both
MediaPlayerPrivateMediaSourceAVFObjC
and MediaPlayerPrivateWebM, the asynchronous requestHostingContext didn't and
was always returning a null contextID which caused the entering PiP path to
exit early.
Manually verified.
An automated regression test isn't achievable at this point due to the testing
infrastucture limitation: iPad simulator only and only having the Mock
PresentationManager.
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::requestHostingContext):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::requestHostingContext):
Canonical link: https://commits.webkit.org/316876@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
