Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0433cfeb9ab17a6b63150f4eec507b660541b7b
      
https://github.com/WebKit/WebKit/commit/a0433cfeb9ab17a6b63150f4eec507b660541b7b
  Author: Yijia Huang <[email protected]>
  Date:   2026-07-03 (Fri, 03 Jul 2026)

  Changed paths:
    A JSTests/stress/temporal-plain-datetime-ctor-nan-infinity.js
    A JSTests/stress/temporal-plain-datetime-round.js
    M Source/JavaScriptCore/runtime/TemporalPlainDatePrototype.cpp
    M Source/JavaScriptCore/runtime/TemporalPlainDateTime.cpp
    M Source/JavaScriptCore/runtime/TemporalPlainDateTime.h
    M Source/JavaScriptCore/runtime/TemporalPlainDateTimeConstructor.cpp
    M Source/JavaScriptCore/runtime/TemporalPlainDateTimePrototype.cpp

  Log Message:
  -----------
  [JSC][Temporal] Polish Temporal.PlainDateTime: spec alignment, constructor 
and round() fixes
https://bugs.webkit.org/show_bug.cgi?id=318454
rdar://181253131

Reviewed by Yusuke Suzuki.

Fix two spec-conformance bugs, remove dead code, and align spec-step
comments across Temporal.PlainDateTime.

The constructor previously accepted NaN on time args (silently coercing
to 0) and skipped trailing arguments; ToIntegerWithTruncation now
throws RangeError on any non-finite value per spec.

Temporal.PlainDateTime.prototype.round dropped a non-ISO calendar
because tryCreateIfValid couldn't carry one. create() and
tryCreateIfValid() now take an optional CalendarID and every
"tryCreateIfValid + setCalendarID" callsite is collapsed accordingly.

Dead code removed: the never-called TemporalPlainDateTime::with()
impl, unreachable inherits<TPDT/PD/ZDT> branches inside fromImpl, the
undefined String&& constructor, the setCalendarID/setCalendarId
accessors, and the duplicated inherits<TPDT> fast-path in
temporalPlainDateTimeConstructorFuncFrom.

Tests:
JSTests/stress/temporal-plain-datetime-ctor-nan-infinity.js
JSTests/stress/temporal-plain-datetime-round.js

Canonical link: https://commits.webkit.org/316498@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to