Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d313f1ef4857987ba09d96600d5d0bcd10b64101
https://github.com/WebKit/WebKit/commit/d313f1ef4857987ba09d96600d5d0bcd10b64101
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-03 (Fri, 03 Jul 2026)
Changed paths:
M Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp
Log Message:
-----------
PageRuntimeAgent::didClearWindowObjectInWorld should check
m_ignoreDidClearWindowObject before minting a frame identifier
https://bugs.webkit.org/show_bug.cgi?id=318540
rdar://181311759
Reviewed by Devin Rousso.
didClearWindowObjectInWorld called identifierRegistry().frameId() before
checking m_ignoreDidClearWindowObject. frameId() is not a pure getter: it
registers the frame in the identifier map (BackendIdentifierRegistry), and
lazily mints a stable identifier (LegacyIdentifierRegistry). On the
reentrant path where frameNavigated() has set m_ignoreDidClearWindowObject
to suppress the duplicate context-created notification, we still performed
that map insertion before bailing out.
The resulting identifier is stable/deterministic either way, so this had no
observable protocol effect, but the ignore check should short-circuit first
to avoid the needless work on the suppressed path.
* Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::didClearWindowObjectInWorld):
Canonical link: https://commits.webkit.org/316488@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
