Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 824d2b29e233c469c079a02ca4c8e24108db69c7
https://github.com/WebKit/WebKit/commit/824d2b29e233c469c079a02ca4c8e24108db69c7
Author: Yusuke Suzuki <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M JSTests/microbenchmarks/intl-number-format-unit-to-parts.js
M Source/JavaScriptCore/runtime/IntlNumberFormat.cpp
M Source/JavaScriptCore/runtime/IntlObject.cpp
M Source/JavaScriptCore/runtime/IntlObject.h
Log Message:
-----------
[JSC] Use modern unit/ skeleton in Intl.NumberFormat
https://bugs.webkit.org/show_bug.cgi?id=318412
rdar://181199699
Reviewed by Sosuke Suzuki.
unit/ skeleton is encouraged in the modern ICU (ICU 67~), let's use them
instead of measure-unit / per-measure-unit. Also removing type field
from MeasureUnit, as type-subtype form is no longer used and it is
kind-of deprecate status in ICU.
Also the reason of the failure in
JSTests/microbenchmarks/intl-number-format-unit-to-parts.js
was because of this legacy format. Now it should work.
https://github.com/unicode-org/icu/blob/main/docs/userguide/format_parse/numbers/skeletons.md#unit
* JSTests/microbenchmarks/intl-number-format-unit-to-parts.js:
* Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):
* Source/JavaScriptCore/runtime/IntlObject.cpp:
* Source/JavaScriptCore/runtime/IntlObject.h:
Canonical link: https://commits.webkit.org/316407@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
