Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b9927430aa6d68ef76529be30df020cd611646a2
https://github.com/WebKit/WebKit/commit/b9927430aa6d68ef76529be30df020cd611646a2
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessor.h
Log Message:
-----------
SVGAnimatedPropertyPairAccessor::detach() causes needless refcount churn by
calling Ref-returning helpers
https://bugs.webkit.org/show_bug.cgi?id=318397
rdar://181183016
Reviewed by Taher Ali.
SVGAnimatedPropertyPairAccessor::detach() called propertyProperty1() and
propertyProperty2(), which each return a Ref<AnimatedProperty> by value.
That constructs a temporary Ref just to call detach() on the pointee,
incurring a ref/deref pair on each call for no reason.
Call property1(owner) and property2(owner) instead, which return
const Ref<AnimatedProperty>& by reference, avoiding the refcount traffic.
The propertyProperty1()/propertyProperty2() helpers had no other callers,
so remove them.
No change in behavior.
* Source/WebCore/svg/properties/SVGAnimatedPropertyPairAccessor.h:
(WebCore::SVGAnimatedPropertyPairAccessor::propertyProperty1 const): Deleted.
(WebCore::SVGAnimatedPropertyPairAccessor::propertyProperty2 const): Deleted.
Canonical link: https://commits.webkit.org/316404@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
