Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 61a168ecf13c414edfcf4e29cab3903c5b8cfc39
https://github.com/WebKit/WebKit/commit/61a168ecf13c414edfcf4e29cab3903c5b8cfc39
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/factories_unittest.py
Log Message:
-----------
[WKCI][build.webkit.org] Move the generate-jsc-bundle step from bot
GTK-Linux-64-bit-Release-Build to GTK-Linux-64bit-Release-Packaging-Nightly
https://bugs.webkit.org/show_bug.cgi?id=318385
Reviewed by Philippe Normand.
This step generates a jsc-bundle and uploads it for third party tests at
https://webkitgtk.org/jsc-built-products/x86_64/release/
The problem is that since we enabled assertions on post-commit release bots
to improve our testing coverage that meant that those built-products started
to be generated with assertions enabled.
And we received a notification of detected performance drops with the last
versions of those builds. That is beause of this assertions, which make jsc
slower because it has to check multiple assertions all the time and the overall
performance regresses because of a death by a thousand of cuts.
We also noticed this on the Motionmark tests that the Perf test bot runs, so
that
is the reason we had to decouple the perf test bot from the default release
builder,
so the perf bot could build its own built products without asserts. See
312685@main
But we overlooked the case of this jsc built products.
So to fix this simply move this step to the packaging bots (that is where it
really
should be) which build without assertions and at much lower frequency (once per
day).
As a side effect of this, there will be a much more meaningful history
available on
the download server, with ability to download old built products as far as 100
days
old rather than only ~two days old as maximum, because those products are
automatically
cleaned by number (last ~100) and not by date, and the previous builder was
uploading
three per hour on average. So, hopefully this would also help users to bisect
more easily.
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
Canonical link: https://commits.webkit.org/316372@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
