Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0f4651107b5a20246a1d7c255c6f4902a30f9b86
https://github.com/WebKit/WebKit/commit/0f4651107b5a20246a1d7c255c6f4902a30f9b86
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
M Source/WebCore/dom/PopoverData.h
Log Message:
-----------
PopoverData::m_popoverState and m_visibilityState are uninitialized
https://bugs.webkit.org/show_bug.cgi?id=318302
rdar://181099545
Reviewed by Charlie Wolfe.
PopoverData default-constructs both m_popoverState and m_visibilityState
without initializers, leaving them holding indeterminate values. While
m_popoverState is set immediately at its sole creation site,
m_visibilityState is only assigned later when the popover is first shown
or hidden, so isPopoverShowing() can read uninitialized memory before
that (e.g. togglePopover() on a freshly-attributed popover). Since
PopoverVisibilityState is an enum : bool, a nonzero garbage byte reads
as Showing.
Give both members in-class initializers.
* Source/WebCore/dom/PopoverData.h:
Canonical link: https://commits.webkit.org/316348@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
