Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 221b4649ae211df8f9da8b219fed14bebc620b4b
https://github.com/WebKit/WebKit/commit/221b4649ae211df8f9da8b219fed14bebc620b4b
Author: Alan Baradlay <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerModelObject.cpp
M Source/WebCore/rendering/RenderLayerModelObject.h
Log Message:
-----------
[cleanup] Move members to the appropriate class among RenderBoxModelObject,
RenderLayerModelObject and RenderBox
https://bugs.webkit.org/show_bug.cgi?id=318067
Reviewed by Antti Koivisto.
A few members lived on the wrong class; move them to where they belong.
contentChanged(), hasAcceleratedCompositing() and the ContentChangeType enum
only
touch the renderer's layer and the compositor, so they move from
RenderBoxModelObject
up to RenderLayerModelObject, the class that owns the layer.
backgroundIsKnownToBeOpaqueInRect() is only meaningful for RenderBox, so it
moves from
a RenderLayerModelObject virtual down to a RenderBox virtual; RenderLayer
reaches it
through renderBox().
canHaveBoxInfoInFragment() is only used in assertions, so it becomes a
debug-only free
function in RenderBox.cpp.
No behavior change.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::canHaveBoxInfoInFragment):
(WebCore::RenderBox::computeOutOfFlowPositionedLogicalWidth const):
(WebCore::RenderBox::computeOutOfFlowPositionedLogicalHeight const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::contentChanged): Deleted.
(WebCore::RenderBoxModelObject::hasAcceleratedCompositing const): Deleted.
* Source/WebCore/rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInFragment const): Deleted.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::contentChanged):
(WebCore::RenderLayerModelObject::hasAcceleratedCompositing const):
* Source/WebCore/rendering/RenderLayerModelObject.h:
(WebCore::RenderLayerModelObject::backgroundIsKnownToBeOpaqueInRect const):
Deleted.
Canonical link: https://commits.webkit.org/316330@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
