Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bc8e9b9cc39741f7727d1bb70ecb9f555b8770ca
https://github.com/WebKit/WebKit/commit/bc8e9b9cc39741f7727d1bb70ecb9f555b8770ca
Author: Alan Baradlay <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxInlines.h
Log Message:
-----------
[cleanup] Tidy up the RenderBox.h header (group methods, move inline bodies
out)
https://bugs.webkit.org/show_bug.cgi?id=318061
Reviewed by Antti Koivisto.
The public section of RenderBox.h had accumulated declarations in a fairly
random
order. Group them by functionality -- position/size, box-edge rects, margins,
overflow,
scrolling, sizing, painting, hit testing, coordinate mapping, fragmentation,
tree
navigation, and so on -- so related methods sit together. The reordering does
not
change any declaration.
Also move tryLayoutDoingOutOfFlowMovementOnly() and
markShapeOutsideDependentsForLayout() out of the class body into
RenderBoxInlines.h,
matching how the rest of RenderBox's inlines are defined, and drop the unused
hasHorizontalLayoutOverflow()/hasVerticalLayoutOverflow(). No behavior change.
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::location const):
(WebCore::RenderBox::locationOffset const):
(WebCore::RenderBox::borderBoxWidth const):
(WebCore::RenderBox::borderBoxHeight const):
(WebCore::RenderBox::borderBoxSize const):
(WebCore::RenderBox::borderBoxRectInContainer const):
(WebCore::RenderBox::setLocation):
(WebCore::RenderBox::setBorderBoxSize):
(WebCore::RenderBox::setBorderBoxInContainer):
(WebCore::RenderBox::move):
(WebCore::RenderBox::layoutOverflowRect const):
(WebCore::RenderBox::visualOverflowRect const):
(WebCore::RenderBox::hasRenderOverflow const):
(WebCore::RenderBox::hasVisualOverflow const):
(WebCore::RenderBox::applyVisualEffectOverflow):
(WebCore::RenderBox::addOverflowFromInFlowChildren):
(WebCore::RenderBox::addOverflowFromContainedBox):
(WebCore::RenderBox::stopAutoscroll):
(WebCore::RenderBox::hasIntrinsicAspectRatio const):
(WebCore::RenderBox::adjustBorderBoxRectForPainting):
(WebCore::RenderBox::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBox::firstLineBaseline const):
(WebCore::RenderBox::lastLineBaseline const):
(WebCore::RenderBox::isGridItem const):
(WebCore::RenderBox::isFlexItem const):
(WebCore::RenderBox::tryLayoutDoingOutOfFlowMovementOnly): Deleted.
(WebCore::RenderBox::hasHorizontalLayoutOverflow const): Deleted.
(WebCore::RenderBox::hasVerticalLayoutOverflow const): Deleted.
(WebCore::RenderBox::markShapeOutsideDependentsForLayout): Deleted.
* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::tryLayoutDoingOutOfFlowMovementOnly):
(WebCore::RenderBox::markShapeOutsideDependentsForLayout):
Canonical link: https://commits.webkit.org/316297@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
