Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 927ccd52454a4e15c09f9930878cbbb6ad51bc23
https://github.com/WebKit/WebKit/commit/927ccd52454a4e15c09f9930878cbbb6ad51bc23
Author: Antti Koivisto <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
R
LayoutTests/css-custom-properties-api/border-variable-parsing-expected.html
R LayoutTests/css-custom-properties-api/border-variable-parsing.html
R LayoutTests/css-custom-properties-api/crash-expected.txt
R LayoutTests/css-custom-properties-api/crash.html
R LayoutTests/css-custom-properties-api/cycles-expected.txt
R LayoutTests/css-custom-properties-api/cycles.html
R LayoutTests/css-custom-properties-api/inherits-expected.txt
R LayoutTests/css-custom-properties-api/inherits.html
R LayoutTests/css-custom-properties-api/initialValue-expected.html
R LayoutTests/css-custom-properties-api/initialValue.html
R LayoutTests/css-custom-properties-api/initialValueJS-expected.txt
R LayoutTests/css-custom-properties-api/initialValueJS.html
R LayoutTests/css-custom-properties-api/inline-expected.txt
R LayoutTests/css-custom-properties-api/inline.html
R LayoutTests/css-custom-properties-api/length-expected.txt
R LayoutTests/css-custom-properties-api/length.html
R LayoutTests/css-custom-properties-api/length2-expected.txt
R LayoutTests/css-custom-properties-api/length2.html
R LayoutTests/css-custom-properties-api/registerProperty-expected.txt
R LayoutTests/css-custom-properties-api/registerProperty.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-cycles-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-attr-substitution-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cycles-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-variable-declaration-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/visionos/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/WebCore/style/StyleSubstitutionResolver.cpp
M Source/WebCore/style/StyleSubstitutionResolver.h
Log Message:
-----------
Resolve var() fallback only when the first arg resolves invalid
https://bugs.webkit.org/show_bug.cgi?id=318327
rdar://181114298
Reviewed by Alan Baradlay.
https://drafts.csswg.org/css-variables-2/#replace-a-var-function
4. If result contains the guaranteed-invalid value, and second arg was
provided, set result
to the result of substitute arbitrary substitution functions on second arg.
Fallback resolution used to be eager but it was changed in
https://github.com/w3c/csswg-drafts/issues/11500.
Also remove LayoutTests/css-custom-properties-api, old Chromium
register-property imports
superseded by the imported css/css-properties-values-api web-platform-tests.
One of them
asserted the pre-short-circuit fallback behavior.
* LayoutTests/css-custom-properties-api/: Removed.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/visionos/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
Remove entries for the deleted directory.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-cycles-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/local-attr-substitution-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cycles-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-variable-declaration-expected.txt:
* Source/WebCore/style/StyleSubstitutionResolver.cpp:
(WebCore::Style::SubstitutionResolver::substituteVariableFunction):
(WebCore::Style::SubstitutionResolver::substituteVariableFallback): Deleted.
* Source/WebCore/style/StyleSubstitutionResolver.h:
Canonical link: https://commits.webkit.org/316280@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
