Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7b38a3e97b1b1559fa0f526c8661c609e2078286
https://github.com/WebKit/WebKit/commit/7b38a3e97b1b1559fa0f526c8661c609e2078286
Author: Wenson Hsieh <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/EditorStateTests.mm
Log Message:
-----------
[Writing Tools] Siri affordance appears after selecting and hovering text,
but remains in the wrong place after you scroll the page
https://bugs.webkit.org/show_bug.cgi?id=318263
rdar://180970146
Reviewed by Richard Robinson and Abrar Rahman Protyasha.
Invoke `-textInputClientDidUpdateSelection` after scrolling or zooming on macOS
to update the Siri
Writing Tools affordance position and visibility. To do this, leverage the
existing
`m_contentRelativeViewsHysteresis` activity timer and keep track of a new flag
(`m_contentRelativeViewsNeedToBeRepositioned`) that schedules an update on the
`NSTextInputClient`
when reset, after scrolling/zooming ends.
Test: EditorStateTests.NotifyTextInputClientAfterMagnificationChange
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::handleProcessSwapOrExit):
(WebKit::WebViewImpl::suppressContentRelativeChildViews):
(WebKit::WebViewImpl::contentRelativeViewsHysteresisTimerFired):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/EditorStateTests.mm:
(TestWebKitAPI::TEST(EditorStateTests,
NotifyTextInputClientAfterMagnificationChange)):
Canonical link: https://commits.webkit.org/316271@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
