Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8e78299db4970d7e9faffc8812c725687e88138a
https://github.com/WebKit/WebKit/commit/8e78299db4970d7e9faffc8812c725687e88138a
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
M Source/WebCore/editing/VisibleUnits.cpp
Log Message:
-----------
nextLineCandidatePosition ignores editableType parameter and hardcodes
ContentIsEditable
https://bugs.webkit.org/show_bug.cgi?id=318192
rdar://181000174
Reviewed by Chris Dumez.
nextLineCandidatePosition() takes an EditableType parameter and threads it
through every call to nextLeafWithSameEditability() except the first
skip-to-next-line loop, which hardcoded ContentIsEditable. This is
inconsistent with the symmetric previousLineCandidatePosition(), which uses
the editableType argument consistently.
There is no behavior change from this patch: every caller reaching this loop
passes ContentIsEditable (the default EditableType), so the hardcoded value
already matched the argument in practice. However, the code was very fragile,
so this is to fix it.
Pass editableType through to nextLeafWithSameEditability() so the loop
respects the requested editability type and stays consistent with
previousLineCandidatePosition().
* Source/WebCore/editing/VisibleUnits.cpp:
(WebCore::nextLineCandidatePosition):
Canonical link: https://commits.webkit.org/316241@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
