Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 87042c9e527f0ba62006d1ac84347743bb0bc079
https://github.com/WebKit/WebKit/commit/87042c9e527f0ba62006d1ac84347743bb0bc079
Author: Ahmad Saleem <[email protected]>
Date: 2026-06-30 (Tue, 30 Jun 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML.html
M Source/WebCore/html/track/WebVTTElement.h
Log Message:
-----------
Misnamed local static voiceAttr in WebVTTElement::langAttributeName()
https://bugs.webkit.org/show_bug.cgi?id=318206
rdar://181007995
Reviewed by Chris Dumez.
The local NeverDestroyed<QualifiedName> in langAttributeName() was
copy-pasted from voiceAttributeName() and left named voiceAttr, even
though it holds the "lang" attribute name. Rename it to langAttr to
match its purpose.
* Source/WebCore/html/track/WebVTTElement.h:
*
LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML.html:
Extend the existing getCueAsHTML() test with <lang> coverage (lang->lang
attribute)
alongside the existing <v> (voice->title) cases, exercising
langAttributeName()'s observable output.
Canonical link: https://commits.webkit.org/316239@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
