Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 88e4fef2d2777c3f1313007b6d1c169fdb8198b1
https://github.com/WebKit/WebKit/commit/88e4fef2d2777c3f1313007b6d1c169fdb8198b1
Author: Ruthvik Konda <[email protected]>
Date: 2026-06-30 (Tue, 30 Jun 2026)
Changed paths:
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
Reduce use of `.get()` for smart pointers in WebModelPlayer
https://bugs.webkit.org/show_bug.cgi?id=318135
rdar://180954475
Reviewed by Mike Wyrzykowski.
`RefPtr<T>` has constructors that take `WeakPtr<T>` and `ThreadSafeWeakPtr<T>`
directly (RefPtr.h:104, 106), calling `.get()` internally. Removing redundant
`.get()` calls at thirteen sites in `WebModelPlayer` simplifies the code
without changing behavior, since the constructor invokes `.get()` itself.
No new tests needed (no behavioral change).
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::ModelDisplayBufferDisplayDelegate::display):
(WebKit::WebModelPlayer::WebModelPlayer):
(WebKit::WebModelPlayer::load):
(WebKit::WebModelPlayer::notifyEntityTransformUpdated):
(WebKit::WebModelPlayer::sizeDidChange):
(WebKit::WebModelPlayer::snapshotCurrentFrame):
(WebKit::WebModelPlayer::scheduleUpdateIfNeeded):
(WebKit::WebModelPlayer::scheduleDisplayUpdate):
(WebKit::WebModelPlayer::setEnvironmentMap):
(WebKit::WebModelPlayer::visibilityStateDidChange):
(WebKit::WebModelPlayer::updateScreenHeadroomFromPage):
Canonical link: https://commits.webkit.org/316173@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
