Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 32f57407f9537ac13b4a18a2593583a2dd40bc56
https://github.com/WebKit/WebKit/commit/32f57407f9537ac13b4a18a2593583a2dd40bc56
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-23 (Tue, 23 Jun 2026)
Changed paths:
M Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
Log Message:
-----------
CoreIPCNSURLRequest decodes the attribution enum from the wrong NSNumber
https://bugs.webkit.org/show_bug.cgi?id=317414
rdar://180044065
Reviewed by Sihui Liu.
The attribution block guards on the "attribution" object but read its numeric
value from the sibling
local `allowedProtocolTypes` (the variable from the immediately preceding
block) instead of
`attribution`. As a result the decoded NSURLRequest carried the
allowedProtocolTypes value as its
NSURLRequestAttribution, or dropped attribution entirely when that value was
out of range. Every
other enum-decode block reads from its own object; read from `attribution` here
too.
Test: Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm:
(WebKit::CoreIPCNSURLRequest::CoreIPCNSURLRequest):
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(TEST(IPCSerialization, NSURLRequestAttribution)):
Canonical link: https://commits.webkit.org/315712@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
