Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2f229114ef117f39ba1445ed660aea69d7f7312f
https://github.com/WebKit/WebKit/commit/2f229114ef117f39ba1445ed660aea69d7f7312f
Author: Alex Christensen <[email protected]>
Date: 2026-06-22 (Mon, 22 Jun 2026)
Changed paths:
A
LayoutTests/http/tests/site-isolation/exit-fullscreen-from-ui-process-expected.txt
A LayoutTests/http/tests/site-isolation/exit-fullscreen-from-ui-process.html
A
LayoutTests/http/tests/site-isolation/resources/exit-fullscreen-from-ui-process.html
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Log Message:
-----------
WebFullScreenManager::requestExitFullScreen should only call close if top
document is present and has no fullscreen element
https://bugs.webkit.org/show_bug.cgi?id=317605
rdar://160964600
Reviewed by Andy Estes.
WebFullScreenManager::requestExitFullScreen has some code that basically says
"if something has gone wrong, just close fullscreen". However, this code was
hit during normal exiting of fullscreen driven by the UI process with site
isolation
enabled because topDocument was null because the main frame was a RemoteFrame.
Adjust the condition to only hit if there is a top document and it has no
fullscreen
element, instead of hitting if we haven't found a top document.
Test: http/tests/site-isolation/exit-fullscreen-from-ui-process.html
*
LayoutTests/http/tests/site-isolation/exit-fullscreen-from-ui-process-expected.txt:
Added.
* LayoutTests/http/tests/site-isolation/exit-fullscreen-from-ui-process.html:
Added.
*
LayoutTests/http/tests/site-isolation/resources/exit-fullscreen-from-ui-process.html:
Added.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::requestExitFullScreen):
Canonical link: https://commits.webkit.org/315633@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
