Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3e14f0ac6667bf77dab8dd3290f17fdd07439af0
https://github.com/WebKit/WebKit/commit/3e14f0ac6667bf77dab8dd3290f17fdd07439af0
Author: Kiet Ho <[email protected]>
Date: 2026-06-22 (Mon, 22 Jun 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/at-rule-with-types-parsing-expected.txt
M Source/WebCore/css/CSSViewTransitionRule.cpp
M Source/WebCore/css/CSSViewTransitionRule.h
Log Message:
-----------
Fix serialization of CSSViewTransitionRule
rdar://180170814
https://bugs.webkit.org/show_bug.cgi?id=317520
Reviewed by Tim Nguyen.
Fix some issues with the serialization (cssText) of @view-transition at-rule:
1. View transition type identifiers aren't escaped for serialization.
e.g: "types: abc\ def" has one type "abc def" ('\' is the escape character),
but is serialized as "types: abc def", which means two types.
2. If any types are specified, the serialization contains an extra bracket
e.g: "@view-transition { types: abc }" is serialized as
"@view-transition { types: abc}}"
3. 'types' is not serialized if it's 'none'
e.g: "@view-transition { types: none; }" is serialized as
"@view-transition { }"
Test:
imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/at-rule-with-types-parsing.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/with-types/at-rule-with-types-parsing-expected.txt:
* Source/WebCore/css/CSSViewTransitionRule.cpp:
(WebCore::StyleRuleViewTransition::StyleRuleViewTransition):
(WebCore::CSSViewTransitionRule::cssText const):
* Source/WebCore/css/CSSViewTransitionRule.h:
Canonical link: https://commits.webkit.org/315614@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
