Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a7a692e87928b06a6d9c1169a8f76ff485231030
https://github.com/WebKit/WebKit/commit/a7a692e87928b06a6d9c1169a8f76ff485231030
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-22 (Mon, 22 Jun 2026)
Changed paths:
M Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
Log Message:
-----------
CoreIPCNSURLCredential encodes flags by iterating the attributes dictionary
https://bugs.webkit.org/show_bug.cgi?id=317451
rdar://180073351
Reviewed by Sihui Liu.
Inside the "flags" block, the loop iterated `attributes` instead of `flags`,
while looking up each
key in `flags` and appending to the flags vector. Keys present only in `flags`
were never emitted,
and keys taken from `attributes` were looked up in `flags`, yielding nil values
that fail the
isKindOfClass:NSString check and break the loop. Iterate `flags`.
Test: Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm:
(WebKit::CoreIPCNSURLCredential::CoreIPCNSURLCredential):
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(TEST(IPCSerialization, NSURLCredentialKerberosFlags)):
Canonical link: https://commits.webkit.org/315612@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
