Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5bccdc64b07a02222366484ee0b702e44caa75f3
https://github.com/WebKit/WebKit/commit/5bccdc64b07a02222366484ee0b702e44caa75f3
Author: Brandon Stewart <[email protected]>
Date: 2026-06-22 (Mon, 22 Jun 2026)
Changed paths:
M Source/ThirdParty/libwebrtc/WebRTCPrefix.h
Log Message:
-----------
[CMake] Build Fix Undefined symbol bssl::CloseFD when linking WebCore
https://bugs.webkit.org/show_bug.cgi?id=317590
rdar://180310399
Reviewed by Geoffrey Garen and Pascoe.
315200@main added third_party/boringssl/src/tool/internal.h to the
libwebrtc prefix header as part of an auto-generated list of headers used
by >= 15 files. That header belongs to the BoringSSL command-line tool,
not the library: it declares ScopedFD, whose inline reset() calls
bssl::CloseFD(), which is only defined in tool/fd.cc -- a file never
compiled into libwebrtc. Pulling it into the PCH caused ScopedFD::reset()
to be emitted as a weak symbol referencing the missing CloseFD, producing
an undefined-symbol error when linking WebCore.
No library source actually includes tool/internal.h or uses ScopedFD, so
remove it from the prefix header.
* Source/ThirdParty/libwebrtc/WebRTCPrefix.h:
Canonical link: https://commits.webkit.org/315608@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
