Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7cab60148a295e42f5b41289870921fd7c2f1c5a
https://github.com/WebKit/WebKit/commit/7cab60148a295e42f5b41289870921fd7c2f1c5a
Author: Ruthvik Konda <[email protected]>
Date: 2026-06-22 (Mon, 22 Jun 2026)
Changed paths:
M
Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebCore/Modules/model-element/HTMLModelElement.h
M Source/WebCore/Modules/model-element/ModelPlayer.cpp
M Source/WebCore/Modules/model-element/ModelPlayer.h
M Source/WebCore/platform/graphics/cocoa/IOSurface.h
M Source/WebCore/platform/graphics/cocoa/IOSurface.mm
M Source/WebCore/rendering/RenderModel.cpp
M Source/WebCore/rendering/RenderModel.h
M Source/WebKit/Configurations/AllowedSPI-legacy.toml
M Source/WebKit/GPUProcess/graphics/Model/MeshImpl.cpp
M Source/WebKit/GPUProcess/graphics/Model/MeshImpl.h
M Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.cpp
M Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.h
M Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.messages.in
M Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.h
M Source/WebKit/WebProcess/Model/Mesh.h
M Source/WebKit/WebProcess/Model/WebModelPlayer.h
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
Reland "[model] <model> element is not captured in Tab Overview snapshots on
macOS"
https://bugs.webkit.org/show_bug.cgi?id=317428
rdar://180054332
Unreviewed, reland.
Relands 315436@main (the <model> Tab Overview snapshot fix, reverted in
315478@main) together with 315457@main (the CGImageSetCachingFlags SPI allowlist
entry, reverted in 315476@main), folded into a single commit.
The previous allowlist entry was an unconditional [[temporary-usage]] block in
AllowedSPI.toml. Because the SPI audit is bidirectional, that passed where the
symbol is compiled (GPU_PROCESS_MODEL on) but failed where it is compiled out
(iOS 26, GPU_PROCESS_MODEL off) with "allowed symbol is not used".
CGImageSetCachingFlags is an existing CoreGraphics SPI already allowed for
WebCore, so add it to AllowedSPI-legacy.toml as a conditional [[legacy]] entry
scoped requires = ["ENABLE_GPU_PROCESS_MODEL"], matching the
#if ENABLE(GPU_PROCESS_MODEL) guard around the use in MeshImpl.cpp. The entry is
only active on builds that compile the use, so both audit directions pass.
*
Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp:
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/ModelPlayer.cpp:
* Source/WebCore/Modules/model-element/ModelPlayer.h:
* Source/WebCore/platform/graphics/cocoa/IOSurface.h:
* Source/WebCore/platform/graphics/cocoa/IOSurface.mm:
* Source/WebCore/rendering/RenderModel.cpp:
* Source/WebCore/rendering/RenderModel.h:
* Source/WebKit/Configurations/AllowedSPI-legacy.toml:
* Source/WebKit/GPUProcess/graphics/Model/MeshImpl.cpp:
* Source/WebKit/GPUProcess/graphics/Model/MeshImpl.h:
* Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.cpp:
* Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.h:
* Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.messages.in:
* Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.cpp:
* Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.h:
* Source/WebKit/WebProcess/Model/Mesh.h:
* Source/WebKit/WebProcess/Model/WebModelPlayer.h:
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
Canonical link: https://commits.webkit.org/315606@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
