Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: efcd683a93b8d90dc6cdf372c37fd2b406b1cfc3
https://github.com/WebKit/WebKit/commit/efcd683a93b8d90dc6cdf372c37fd2b406b1cfc3
Author: Sosuke Suzuki <[email protected]>
Date: 2026-06-21 (Sun, 21 Jun 2026)
Changed paths:
A JSTests/stress/intl-pluralrules-compactdisplay.js
M JSTests/test262/expectations.yaml
M Source/JavaScriptCore/runtime/IntlNumberFormatInlines.h
M Source/JavaScriptCore/runtime/IntlPluralRules.cpp
Log Message:
-----------
[JSC] `Intl.PluralRules` should reflect `compactDisplay` in skeleton and
`resolvedOptions`
https://bugs.webkit.org/show_bug.cgi?id=317534
Reviewed by Yusuke Suzuki.
315426@main added m_compactDisplay to IntlPluralRules and read the
"compactDisplay" option in initializePluralRules, but the value was never
used: appendNumberFormatNotationOptionsToSkeleton still hardcoded
"compact-short" for IntlPluralRules, and resolvedOptions() did not expose
the property.
This patch removes the IntlPluralRules special case from
appendNumberFormatNotationOptionsToSkeleton so that m_compactDisplay is
passed to ICU, and emits "compactDisplay" from resolvedOptions() right
after "notation" when notation is "compact", per the Resolved Options of
PluralRules Instances table.
Test: JSTests/stress/intl-pluralrules-compactdisplay.js
* JSTests/stress/intl-pluralrules-compactdisplay.js: Added.
(shouldBe):
(throw.new.Error):
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/IntlNumberFormatInlines.h:
(JSC::appendNumberFormatNotationOptionsToSkeleton):
* Source/JavaScriptCore/runtime/IntlPluralRules.cpp:
(JSC::IntlPluralRules::resolvedOptions const):
Canonical link: https://commits.webkit.org/315566@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
