Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7b7f430e0f22e21a9da2b29120e4b3226297cd34
https://github.com/WebKit/WebKit/commit/7b7f430e0f22e21a9da2b29120e4b3226297cd34
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-17 (Wed, 17 Jun 2026)
Changed paths:
M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp
Log Message:
-----------
Remove redundant validation in WebCodecs VideoFrame buffer construction
https://bugs.webkit.org/show_bug.cgi?id=317170
rdar://179759495
Reviewed by Youenn Fablet.
validateI420Sizes() rejected odd visibleRect offsets for I420/NV12/I420A
buffer-constructed frames,
but it could never actually fire: it runs only after parseVisibleRect(), whose
verifyRectOffsetAlignment() already enforces even x and y offsets for a
superset of those formats
({I420, I420A, I422, NV12}) and throws a TypeError first. The function was
therefore dead code —
and it also had a typo (it tested visibleRect->x twice instead of x and y),
which was masked because
the check was unreachable.
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
(WebCore::WebCodecsVideoFrame::create):
(WebCore::validateI420Sizes): Deleted.
Canonical link: https://commits.webkit.org/315394@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
