Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: da28ce6d739302bd6c29708a52e8be9beb05c494
https://github.com/WebKit/WebKit/commit/da28ce6d739302bd6c29708a52e8be9beb05c494
Author: Claudio Saavedra <[email protected]>
Date: 2026-06-17 (Wed, 17 Jun 2026)
Changed paths:
M Source/cmake/FindGStreamer.cmake
Log Message:
-----------
[CMake] find_package(GStreamer) reports success even when GStreamer is not
found
https://bugs.webkit.org/show_bug.cgi?id=317298
Reviewed by Philippe Normand.
FindGStreamer.cmake builds the list of variables that must be set for the
package to be considered found in _GSTREAMER_REQUIRED_VARS, but passes the
*name* of that list variable to FIND_PACKAGE_HANDLE_STANDARD_ARGS() instead
of its expansion.
As a result FPHSA only checks that _GSTREAMER_REQUIRED_VARS
itself is set and never checks GSTREAMER_INCLUDE_DIRS,
GSTREAMER_LIBRARIES or the per-component variables. GStreamer is therefore
reported as found (and the REQUIRED check passes) even when pkg-config failed
to locate it and the include/library variables are empty.
* Source/cmake/FindGStreamer.cmake:
Canonical link: https://commits.webkit.org/315375@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
