Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e92b564759d82c4c5e14f37f875ccf6b8befbbfa
https://github.com/WebKit/WebKit/commit/e92b564759d82c4c5e14f37f875ccf6b8befbbfa
Author: Tyler Wilcock <[email protected]>
Date: 2026-06-16 (Tue, 16 Jun 2026)
Changed paths:
A
LayoutTests/accessibility/mac/text-marker-string-excludes-checkmark-content-expected.txt
A
LayoutTests/accessibility/mac/text-marker-string-excludes-checkmark-content.html
A
LayoutTests/accessibility/mac/text-marker-string-excludes-generated-content-expected.txt
A
LayoutTests/accessibility/mac/text-marker-string-excludes-generated-content.html
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Log Message:
-----------
AX: Isolated tree includes ::before/::after generated content in text marker
strings and should not do so
https://bugs.webkit.org/show_bug.cgi?id=317039
rdar://179521442
Reviewed by Chris Fleizach and Dominic Mazzoni.
AccessibilityRenderObject::textRuns() emitted a text run for ::before/::after
generated
content, which the isolated tree caches and serves during text-marker
stringification.
The live tree (TextIterator) and AccessibilityObject::simpleRange(), in
contrast, do not
allow this, and in general CSS generated content cannot be selected or
otherwise used in
DOM positions.
To match the live tree and accurately reflect the page text state, we should
(and with this
commit, do) stop generating text runs for this content.
Beyond passing new test
accessibility/mac/text-marker-string-excludes-generated-content.html,
this gets us closer to passing
accessibility/mac/pseudo-element-text-markers.html with isolated
tree mode enabled.
*
LayoutTests/accessibility/mac/text-marker-string-excludes-checkmark-content-expected.txt:
Added.
*
LayoutTests/accessibility/mac/text-marker-string-excludes-checkmark-content.html:
Added.
*
LayoutTests/accessibility/mac/text-marker-string-excludes-generated-content-expected.txt:
Added.
*
LayoutTests/accessibility/mac/text-marker-string-excludes-generated-content.html:
Added.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::shouldExcludeTextRunsForPseudoElement):
(WebCore::AccessibilityRenderObject::textRuns):
Canonical link: https://commits.webkit.org/315282@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
