Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bb90dd1d02eecf2e00bec9a4871414982b3f7144
https://github.com/WebKit/WebKit/commit/bb90dd1d02eecf2e00bec9a4871414982b3f7144
Author: Sihui Liu <[email protected]>
Date: 2026-06-15 (Mon, 15 Jun 2026)
Changed paths:
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/platform/LogMessages.in
Log Message:
-----------
Reduce log volume from HTMLMediaElement and HTMLCanvasElement to avoid logd
quarantine
https://bugs.webkit.org/show_bug.cgi?id=316636
rdar://179070968
Reviewed by Per Arne Vollan.
HTMLMEDIAELEMENT_RELEASE_LOG expands to RELEASE_LOG_FORWARDABLE, which on the
LOGD_BLOCKING_IN_WEBCONTENT path
forwards log messages via IPC to the UI process, where they are emitted with
os_log_with_type() at the level
specified in LogMessages.in — currently OS_LOG_TYPE_DEFAULT. Messages at this
level are unconditionally persisted
by logd. During benchmarks or on any page with video, the entry-point logs for
play(), pause(), playInternal(),
pauseInternal(), setAutoplayEventPlaybackState(), and
dispatchPlayPauseEventsIfNeedsQuirks() fire very frequently
— enough to trigger logd's per-process quarantine, after which WebKit clients
lose all logging capability for the
remainder of the run.
These entry-point logs carry no diagnostic value beyond announcing that a
function was called. All actionable failure
paths already have their own ERROR_LOG or ALWAYS_LOG coverage (e.g. "rejecting
promise:", "playback not permitted:",
"returning because of interruption"). Change those seven entries in
LogMessages.in from DEFAULT to INFO, so the
generated LogStream implementations emit OS_LOG_TYPE_INFO. The messages are no
longer unconditionally persisted by
logd — eliminating the quarantine contribution — but remain available in
sysdiagnoses and when info-level logging
is explicitly enabled.
Also reduce the HTMLCanvasElement fingerprinting-mitigation log from
OS_LOG_TYPE_DEFAULT to OS_LOG_TYPE_INFO. The
console message added on the same code path is the appropriate user-facing
notification; the OS log entry only needs
to be available when info-level logging is explicitly enabled.
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
* Source/WebCore/platform/LogMessages.in:
Canonical link: https://commits.webkit.org/315258@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
