Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aaaf1924a17cf39a0629ac968c1def97e82cfe73
      
https://github.com/WebKit/WebKit/commit/aaaf1924a17cf39a0629ac968c1def97e82cfe73
  Author: Geoffrey Garen <[email protected]>
  Date:   2026-06-14 (Sun, 14 Jun 2026)

  Changed paths:
    M Source/WebCore/PAL/pal/CMakeLists.txt
    M Source/WebCore/PAL/pal/PlatformCocoa.cmake
    M Source/WebCore/PAL/pal/PlatformMac.cmake
    A Source/WebCore/PAL/pal/Sources.txt
    A Source/WebCore/PAL/pal/SourcesCocoa.txt
    A Source/WebCore/PAL/pal/SourcesMac.txt
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/CMakeLists.txt
    M Source/WebGPU/WGSL/IOValidator.cpp
    M Source/WebGPU/WGSL/Parser.cpp
    A Source/WebGPU/WGSL/Sources.txt
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/WGSL.cpp
    M Source/WebGPU/WGSL/WGSLEnums.cpp
    M Source/WebGPU/WebGPU/CMakeLists.txt
    A Source/WebGPU/WebGPU/Sources.txt
    M Source/cmake/WebKitFS.cmake
    M Source/cmake/WebKitMacros.cmake

  Log Message:
  -----------
  [CMake] WebGPU, WGSL, and PAL should build with unified sources
https://bugs.webkit.org/show_bug.cgi?id=317092
rdar://179647431

Reviewed by David Kilzer.

While we're here, also stop building WGSL twice (!!).

Saves ~8s (2.3%) / 33 CPUs in a clean build.

* Source/WebCore/PAL/pal/CMakeLists.txt: Adopt Sources.txt.

Keep Swift interop sources separate, like we do in other projects,
to prevent serializing all compilation on the Swift interop header.

* Source/WebCore/PAL/pal/PlatformCocoa.cmake: Adopt SourcesCocoa.txt.

* Source/WebCore/PAL/pal/PlatformMac.cmake: Adopt SourcesMac.txt.

* Source/WebCore/PAL/pal/Sources.txt:
* Source/WebCore/PAL/pal/SourcesCocoa.txt:
* Source/WebCore/PAL/pal/SourcesMac.txt: Unified source lists.

* Source/WebGPU/WGSL/AttributeValidator.cpp: Removed some dead
code that caused a name conflict when bundled.

* Source/WebGPU/WGSL/CMakeLists.txt: Adopt Sources.txt.

* Source/WebGPU/WGSL/IOValidator.cpp:
* Source/WebGPU/WGSL/Parser.cpp:
* Source/WebGPU/WGSL/TypeCheck.cpp:
* Source/WebGPU/WGSL/WGSL.cpp:
* Source/WebGPU/WGSL/WGSLEnums.cpp: Undef macros that caused a name
conflict when bundled.

* Source/WebGPU/WGSL/Sources.txt: Unified source list.

* Source/WebGPU/WebGPU/CMakeLists.txt: Adopt Sources.txt.

Link WGSLCore instead of compiling it a second time (!!).

* Source/WebGPU/WebGPU/Sources.txt: Unified source list.

* Source/cmake/WebKitFS.cmake: Supply a derived sources location because
unified sources are derived sources.

Fixed an oversight that treated an @no-unify on a top-level source file
as a generated source file.

Canonical link: https://commits.webkit.org/315190@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to