Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2f69275f43c6036b415a991fcdc924cce4949fb0
https://github.com/WebKit/WebKit/commit/2f69275f43c6036b415a991fcdc924cce4949fb0
Author: Zak Ridouh <[email protected]>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M LayoutTests/http/tests/loading/bad-server-subframe-expected.txt
M LayoutTests/http/tests/loading/bad-server-subframe.html
M LayoutTests/platform/ios-site-isolation/TestExpectations
M LayoutTests/platform/mac-site-isolation/TestExpectations
R
LayoutTests/platform/wk2/http/tests/loading/bad-server-subframe-expected.txt
Log Message:
-----------
[Site Isolation] Fix failing bad-server-subframe.html by not depending on
frame load callback ordering
https://bugs.webkit.org/show_bug.cgi?id=316846
rdar://179283527
Reviewed by Alex Christensen.
http/tests/loading/bad-server-subframe.html used
testRunner.dumpFrameLoadCallbacks(),
whose ordering is non-deterministic with site isolation. The subframe targets an
unreachable server and fails in a separate process, so its
didFailProvisionalLoadWithError
is reported before the cross-process notification that unblocks the main
frame's onload,
flipping the callback order versus the single-process baseline. The behavior is
correct;
only the observed ordering differs.
Rewrite the test to assert the actual invariant, an unreachable subframe must
not
prevent the main frame from firing its load event, which is
ordering-independent and
passes in both configurations. Remove the now-stale wk2 baseline and the
site-isolation
TestExpectations entries.
* LayoutTests/http/tests/loading/bad-server-subframe-expected.txt:
* LayoutTests/http/tests/loading/bad-server-subframe.html:
* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/platform/wk2/http/tests/loading/bad-server-subframe-expected.txt:
Removed.
Canonical link: https://commits.webkit.org/315186@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
