Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 65f1020983d8e3aaba1454d3e1467f5b5fdab41f
https://github.com/WebKit/WebKit/commit/65f1020983d8e3aaba1454d3e1467f5b5fdab41f
Author: Alex Christensen <[email protected]>
Date: 2026-06-13 (Sat, 13 Jun 2026)
Changed paths:
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Only inform WKNavigationDelegate when main frame process
crashes
https://bugs.webkit.org/show_bug.cgi?id=317053
rdar://177903694
Reviewed by Ben Nham.
In 2024 we discussed what would be the best user experience when an iframe
process
crashes with site isolation enabled, a condition that had naver been seen
before.
We decided doing nothing would be the best user experience, but just continuing
to
show the frames that had not crashed. I even wrote some tests for it, for
example
http/tests/site-isolation/iframe-process-termination.html.
In 285735@main I broke this in order to get more crash data from
WebKitTestRunner.
It is useful to continue to get those crashes when using WKPageNavigationClient,
but when using WKNavigationDelegate it is best to do nothing.
Before this change, when an iframe process crashes the whole page is reloaded,
and
when it happens multiple times Safari shows a banner that says an issue was hit
multiple times. After this change, in that case we just lose the iframe content
but the rest of the page continues functioning normally.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::getpid const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::processDidTerminate):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::(SiteIsolation, NonMainFrameProcessCrash)):
Canonical link: https://commits.webkit.org/315183@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
