Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a9810613686c552010aa8877434aae64943f4a1d
https://github.com/WebKit/WebKit/commit/a9810613686c552010aa8877434aae64943f4a1d
Author: Sihui Liu <[email protected]>
Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths:
M Source/WebCore/page/Frame.cpp
M Source/WebKit/Shared/FrameInfoData.cpp
M Source/WebKit/Shared/FrameInfoData.h
M Source/WebKit/Shared/FrameInfoData.serialization.in
M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M
Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/DeviceOrientation.mm
Log Message:
-----------
Use requesting origin instead of active origin for DeviceOrientation
permission request
rdar://168597925
Reviewed by Chris Dumez.
The current implementation uses active origin (origin being navigating to)
instead of requesting origin in permission
prompt, and this might lead to permission being granted to a wrong origin.
API test: DeviceOrientation.PermissionOriginDuringPendingNavigation
* Source/WebCore/page/Frame.cpp:
* Source/WebKit/Shared/FrameInfoData.cpp:
(WebKit::legacyEmptyFrameInfo):
* Source/WebKit/Shared/FrameInfoData.h:
* Source/WebKit/Shared/FrameInfoData.serialization.in:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::shouldAllowDeviceOrientationAndMotionAccess):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::cancel):
*
Source/WebKit/UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp:
(WebKit::WebDeviceOrientationAndMotionAccessController::shouldAllowAccess):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::navigationActionData const):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::info const):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getFrameTreeForBackForwardCacheEntry):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/DeviceOrientation.mm:
((DeviceOrientation, PermissionOriginDuringPendingNavigation)):
Originally-landed-as: 305413.367@rapid/safari-7624.2.5.110-branch (322ddc5).
rdar://176067147
Canonical link: https://commits.webkit.org/315163@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
