Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e45d28fa049b26e8a2c1d67ad4974c50c37b89b3
https://github.com/WebKit/WebKit/commit/e45d28fa049b26e8a2c1d67ad4974c50c37b89b3
Author: Tyler Wilcock <[email protected]>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
A
LayoutTests/accessibility/mac/line-range-includes-trailing-line-break-expected.txt
A LayoutTests/accessibility/mac/line-range-includes-trailing-line-break.html
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
AX: Accessibility thread's implementation of
NSAccessibilityLineTextMarkerRangeForTextMarkerAttribute should include
trailing line breaks just as the main-thread implementation does
https://bugs.webkit.org/show_bug.cgi?id=316909
rdar://179366035
Reviewed by Dominic Mazzoni.
The TextUnit::Line branch of -lineTextMarkerRangeForTextMarker:forUnit: called
AXTextMarker::lineRange() with the default IncludeTrailingLineBreak::No, so the
isolated tree dropped a line's trailing <br>, diverging from the non-isolated
tree and from AXRangeForLine (doAXRangeForLine / characterRangeForLine, which
already include it). Pass IncludeTrailingLineBreak::Yes for the Line unit
(LeftLine/RightLine keep No, matching left/rightLineVisiblePositionRange).
This change also gets accessibility/mac/content-editable-attributed-string.html
closer to passing with --accessibility-isolated-tree.
*
LayoutTests/accessibility/mac/line-range-includes-trailing-line-break-expected.txt:
Added.
* LayoutTests/accessibility/mac/line-range-includes-trailing-line-break.html:
Added.
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper lineTextMarkerRangeForTextMarker:forUnit:]):
Canonical link: https://commits.webkit.org/315042@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
