Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4e06d306cde23dd84205b20a52e9e6c79cf5f169
https://github.com/WebKit/WebKit/commit/4e06d306cde23dd84205b20a52e9e6c79cf5f169
Author: Kimmo Kinnunen <[email protected]>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesMtl_autogen.h
M Source/ThirdParty/ANGLE/include/platform/mtl_features.json
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/FrameBufferMtl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/FrameBufferMtl.mm
M Source/ThirdParty/ANGLE/src/tests/gl_tests/DrawBuffersTest.cpp
M Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.cpp
M Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.h
Log Message:
-----------
ANGLE: DrawBuffersAnyFormat tests fail with MSAA, RG16, AMD
https://bugs.webkit.org/show_bug.cgi?id=316392
rdar://178807945
Reviewed by Dan Glastonbury.
Appears that AMD, at least Radeon 5500M Metal driver has problems with
RG16Unorm pixel format and multisampling. The render pass clear operation
does not clear all the attachments.
Workaround by clearing with a draw.
Change the test to test also 8 sample variants, as AMD/Intel support those.
Change the test to assume all MSAA variants have the same completeness
limit, as they do.
Fixes:
MSAA/DrawBuffersAnyFormatTestES3.ClearIterativeAttachmentCount/ES3_Metal__GL_RG16_EXT_*_MSAA*
* Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesMtl_autogen.h:
* Source/ThirdParty/ANGLE/include/platform/mtl_features.json:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:
(rx::DisplayMtl::initializeFeatures):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/FrameBufferMtl.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/FrameBufferMtl.mm:
(rx::FramebufferMtl::clearImpl):
(rx::FramebufferMtl::needsRG16UnormMSAAClearWorkaround const):
* Source/ThirdParty/ANGLE/src/tests/gl_tests/DrawBuffersTest.cpp:
* Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.cpp:
* Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.h:
Canonical link: https://commits.webkit.org/315009@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
